fix(api): liquid digest step variable parsing fixes NV-6757 #9280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy preview added
To edit notification comments on pull requests, go to your Netlify project configuration. |
github-actions
bot
changed the title
|
✅ PR title automatically updated! I found the Linear ticket ID Updated title: |
ChmaraX
commented
Oct 2, 2025
|
|
||
| // Now match variable patterns from the processed condition | ||
| const variableMatches = processedCondition.match(/[a-zA-Z_][a-zA-Z0-9_]*(?:\.[a-zA-Z_][a-zA-Z0-9_]*)*(?:\[\d+\])*/g); | ||
| const variableMatches = processedCondition.match(/[a-zA-Z_][a-zA-Z0-9_[\].-]+/g); |
There was a problem hiding this comment.
More permissive regex, since we later have a validation of extracted variables against schema, its safer approach to rather extract even potentially invalid ones like "steps.events..[abc]" and then disallow them later as opposed to do complicated regex and risk missing extraction of even valid ones.
ChmaraX
deleted the
nv-6757-liquid-raw-conditions-fail-when-hyphen-is-present-eg-digest
branch
ChmaraX
restored the
nv-6757-liquid-raw-conditions-fail-when-hyphen-is-present-eg-digest
branch
ChmaraX
added a commit
that referenced
this pull request
Oct 2, 2025
ChmaraX
added a commit
that referenced
this pull request
Oct 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
Screenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer